Re: [PATCH v3] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

Alexandre Belloni
2015-05-30T21:56:44Z

On 28/05/2015 at 08:48:45 +0200, Jan Kardell wrote :
> Return -EINVAL if the voltage low bit is set to avoid getting a bogus
> time at boot.
> There was a comment stating that util-linux hwclock refuses to set a
> new time if we return an error code on read, but at least the current
> version do set the time as expected. Remove the comment and the check
> for valid time, and let the rtc core check it for us.
>
> Changes in v2: Remove the test for invalid time. Change dev_err to
> dev_info when voltage low is set.
>
> Changes in v3: Use dev_err when voltage low is set.
>
> Signed-off-by: Jan Kardell <jan.kardell@telliq.com>
> ---
> drivers/rtc/rtc-pcf8563.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering