From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
Behan Webster <behanw@converseincode.com>,
Matthew Casey <mdcasey@chabloom.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix
Date: Sun, 31 May 2015 09:27:55 +0900 [thread overview]
Message-ID: <20150531002755.GA23875@kroah.com> (raw)
In-Reply-To: <1431488590-923-1-git-send-email-tolga.ceylan@gmail.com>
On Tue, May 12, 2015 at 08:43:10PM -0700, Tolga Ceylan wrote:
> Error code returned from auth_parse() should in cpu byte order. Issue
> caught by sparse warning: cast from restricted __le16.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 8f5e88b..98afd3b 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
> return -ENOMEM;
> }
> }
> - return cpu_to_le16(a->status);
> + return le16_to_cpu(a->status);
Doesn't apply to my tree :(
prev parent reply other threads:[~2015-05-31 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 3:43 [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix Tolga Ceylan
2015-05-31 0:27 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531002755.GA23875@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=behanw@converseincode.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=mdcasey@chabloom.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox