From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757911AbbEaAmJ (ORCPT ); Sat, 30 May 2015 20:42:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38449 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757770AbbEaAmD (ORCPT ); Sat, 30 May 2015 20:42:03 -0400 Date: Sun, 31 May 2015 09:27:55 +0900 From: Greg Kroah-Hartman To: Tolga Ceylan Cc: Mateusz Kulikowski , Behan Webster , Matthew Casey , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix Message-ID: <20150531002755.GA23875@kroah.com> References: <1431488590-923-1-git-send-email-tolga.ceylan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431488590-923-1-git-send-email-tolga.ceylan@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2015 at 08:43:10PM -0700, Tolga Ceylan wrote: > Error code returned from auth_parse() should in cpu byte order. Issue > caught by sparse warning: cast from restricted __le16. > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > index 8f5e88b..98afd3b 100644 > --- a/drivers/staging/rtl8192e/rtllib_softmac.c > +++ b/drivers/staging/rtl8192e/rtllib_softmac.c > @@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen) > return -ENOMEM; > } > } > - return cpu_to_le16(a->status); > + return le16_to_cpu(a->status); Doesn't apply to my tree :(