Re: [RFC 07/24] x86/thinkpad_acpi: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

Henrique de Moraes Holschuh
2015-06-03T10:37:19Z

On Wed, Jun 3, 2015, at 00:34, Darren Hart wrote:
> On Tue, Jun 02, 2015 at 07:09:28AM -0300, Henrique de Moraes Holschuh
> wrote:
> > Test results were sent to me privately, and they are correct, so...
>
> Finn, unless there is some compelling reason not to - like they are MBs
> worth of
> data, please submit these to the list in the future so we have them for
> reference.

After I told him which exact bitmask to use on a T43 to test
hotkey_source_mask, his test results can be summarized as "I could see
no difference in behavior", which is *exactly* what I expected to
happen.

If anything went wrong with the thinkpad-acpi NVRAM code, you'd notice a
very large change in behavior (typical: hotkeys don't work, less
typical: random hotkey keypresses, hotkey press bursts, low responsivity
of hotkeys).

> > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
> I'm fine with the changes, but they need to be submitted with the other
> changes
> as this one change cannot compile independently in my tree.
>
> Finn, please work with whomever is pulling the series to include this in
> their
> pull request.
>
> Reviewed-by: Darren Hart <dvhart@linux.intel.com>

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh