From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Douglas Barbonaglia Sathler Figueiredo
<eng.douglasfigueiredo@gmail.com>
Cc: vitaly.osipov@gmail.com, matt@ninezulu.com,
tapaswenipathak@gmail.com, artemiyv@acm.org,
raghav3276@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix long line
Date: Sun, 31 May 2015 10:01:42 +0900 [thread overview]
Message-ID: <20150531010142.GA10897@kroah.com> (raw)
In-Reply-To: <1432052022-13944-1-git-send-email-eng.douglasfigueiredo@gmail.com>
On Tue, May 19, 2015 at 01:13:42PM -0300, Douglas Barbonaglia Sathler Figueiredo wrote:
> Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
>
> Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..f4525f8 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
> continue;
> }
>
> - /* Validate plug address against chunk data and identify chunk */
> + /*
> + * Validate plug address against
> + * chunk data and identify chunk
> + */
> for (c = 0; c < nfchunks; c++) {
> cstart = fchunk[c].addr;
> cend = fchunk[c].addr + fchunk[c].len;
> @@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
> rcnt,
> s3info[ns3info].len,
> s3info[ns3info].type);
> - if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
> + if (((s3info[ns3info].len - 1) * sizeof(u16)) >
> + sizeof(s3info[ns3info].info)) {
Align this under the ( so it doesn't look like it's the logic in the
next block.
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-31 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 16:13 [PATCH] staging: wlan-ng: fix long line Douglas Barbonaglia Sathler Figueiredo
2015-05-31 1:01 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 2:00 Douglas Barbonaglia Sathler Figueiredo
2015-06-01 4:02 ` Greg Kroah-Hartman
2015-06-01 13:37 Douglas Barbonaglia Sathler Figueiredo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531010142.GA10897@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=artemiyv@acm.org \
--cc=devel@driverdev.osuosl.org \
--cc=eng.douglasfigueiredo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ninezulu.com \
--cc=raghav3276@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox