* [PATCH] staging: wlan-ng: fix long line
@ 2015-05-19 16:13 Douglas Barbonaglia Sathler Figueiredo
2015-05-31 1:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Douglas Barbonaglia Sathler Figueiredo @ 2015-05-19 16:13 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: vitaly.osipov, matt, tapaswenipathak, artemiyv, raghav3276, devel,
linux-kernel, Douglas Barbonaglia Sathler Figueiredo
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com>
---
drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 9408644..f4525f8 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
continue;
}
- /* Validate plug address against chunk data and identify chunk */
+ /*
+ * Validate plug address against
+ * chunk data and identify chunk
+ */
for (c = 0; c < nfchunks; c++) {
cstart = fchunk[c].addr;
cend = fchunk[c].addr + fchunk[c].len;
@@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
rcnt,
s3info[ns3info].len,
s3info[ns3info].type);
- if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
+ if (((s3info[ns3info].len - 1) * sizeof(u16)) >
+ sizeof(s3info[ns3info].info)) {
pr_err("S3 inforec length too long - aborting\n");
return 1;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: wlan-ng: fix long line
2015-05-19 16:13 [PATCH] staging: wlan-ng: fix long line Douglas Barbonaglia Sathler Figueiredo
@ 2015-05-31 1:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-05-31 1:01 UTC (permalink / raw)
To: Douglas Barbonaglia Sathler Figueiredo
Cc: vitaly.osipov, matt, tapaswenipathak, artemiyv, raghav3276, devel,
linux-kernel
On Tue, May 19, 2015 at 01:13:42PM -0300, Douglas Barbonaglia Sathler Figueiredo wrote:
> Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
>
> Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..f4525f8 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
> continue;
> }
>
> - /* Validate plug address against chunk data and identify chunk */
> + /*
> + * Validate plug address against
> + * chunk data and identify chunk
> + */
> for (c = 0; c < nfchunks; c++) {
> cstart = fchunk[c].addr;
> cend = fchunk[c].addr + fchunk[c].len;
> @@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
> rcnt,
> s3info[ns3info].len,
> s3info[ns3info].type);
> - if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
> + if (((s3info[ns3info].len - 1) * sizeof(u16)) >
> + sizeof(s3info[ns3info].info)) {
Align this under the ( so it doesn't look like it's the logic in the
next block.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: wlan-ng: fix long line
@ 2015-06-01 2:00 Douglas Barbonaglia Sathler Figueiredo
2015-06-01 4:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Douglas Barbonaglia Sathler Figueiredo @ 2015-06-01 2:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: vitaly.osipov, matt, tapaswenipathak, artemiyv, raghav3276, devel,
linux-kernel, douglasbsf
From: douglasbsf <eng.douglasfigueiredo@gmail.com>
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com>
---
drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 9408644..fe36613 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
continue;
}
- /* Validate plug address against chunk data and identify chunk */
+ /*
+ * Validate plug address against
+ * chunk data and identify chunk
+ */
for (c = 0; c < nfchunks; c++) {
cstart = fchunk[c].addr;
cend = fchunk[c].addr + fchunk[c].len;
@@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
rcnt,
s3info[ns3info].len,
s3info[ns3info].type);
- if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
+ if (((s3info[ns3info].len - 1) * sizeof(u16)) >
+ sizeof(s3info[ns3info].info)) {
pr_err("S3 inforec length too long - aborting\n");
return 1;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: wlan-ng: fix long line
2015-06-01 2:00 Douglas Barbonaglia Sathler Figueiredo
@ 2015-06-01 4:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-06-01 4:02 UTC (permalink / raw)
To: Douglas Barbonaglia Sathler Figueiredo
Cc: vitaly.osipov, matt, tapaswenipathak, artemiyv, raghav3276, devel,
linux-kernel
On Sun, May 31, 2015 at 11:00:28PM -0300, Douglas Barbonaglia Sathler Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>
That's not your "real name", please use the same name you use in the
signed-off-by line.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: wlan-ng: fix long line
@ 2015-06-01 13:37 Douglas Barbonaglia Sathler Figueiredo
0 siblings, 0 replies; 5+ messages in thread
From: Douglas Barbonaglia Sathler Figueiredo @ 2015-06-01 13:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: vitaly.osipov, matt, tapaswenipathak, artemiyv, raghav3276, devel,
linux-kernel, Douglas Barbonaglia Sathler Figueiredo
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: Douglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com>
---
drivers/staging/wlan-ng/prism2fw.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 9408644..fe36613 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -708,7 +708,10 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
continue;
}
- /* Validate plug address against chunk data and identify chunk */
+ /*
+ * Validate plug address against
+ * chunk data and identify chunk
+ */
for (c = 0; c < nfchunks; c++) {
cstart = fchunk[c].addr;
cend = fchunk[c].addr + fchunk[c].len;
@@ -923,7 +926,8 @@ static int read_fwfile(const struct ihex_binrec *record)
rcnt,
s3info[ns3info].len,
s3info[ns3info].type);
- if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
+ if (((s3info[ns3info].len - 1) * sizeof(u16)) >
+ sizeof(s3info[ns3info].info)) {
pr_err("S3 inforec length too long - aborting\n");
return 1;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-01 13:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 16:13 [PATCH] staging: wlan-ng: fix long line Douglas Barbonaglia Sathler Figueiredo
2015-05-31 1:01 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 2:00 Douglas Barbonaglia Sathler Figueiredo
2015-06-01 4:02 ` Greg Kroah-Hartman
2015-06-01 13:37 Douglas Barbonaglia Sathler Figueiredo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox