[PATCH] staging: unisys: use schedule_timeout_interruptible()

[PATCH] staging: unisys: use schedule_timeout_interruptible()

[Nicholas Mc Guire]

API consolidation with coccinelle found:
./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
        consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion with respect to schedule_timeout() to the 
schedule_timeout_interruptible() helper only - so only an API 
consolidation to improve readability. The hard coded timeout of 10
jiffies is HZ dependent which it should not be, so it is converted
with msecs_to_jiffies.

Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m

Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

As the actually intended timeout is not documented and msecs_to_jiffies
timeouts can be a factor 10 different from the current effective timeout
this needs to be checked by someone who knows the details of this driver
in any case it should be passed in a HZ independent manner.

 drivers/staging/unisys/visorbus/periodic_work.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/periodic_work.c b/drivers/staging/unisys/visorbus/periodic_work.c
index 3562e8b..5e56088 100644
--- a/drivers/staging/unisys/visorbus/periodic_work.c
+++ b/drivers/staging/unisys/visorbus/periodic_work.c
@@ -192,8 +192,7 @@ bool visor_periodic_work_stop(struct periodic_work *pw)
 		}
 		if (pw->is_scheduled) {
 			write_unlock(&pw->lock);
-			__set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(10);
+			schedule_timeout_interruptible(msecs_to_jiffies(10));
 			write_lock(&pw->lock);
 		} else {
 			pw->want_to_stop = false;
-- 
1.7.10.4

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

[Greg Kroah-Hartman]

On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
>         consolidation with schedule_timeout_*() recommended
> 
> This is a 1:1 conversion with respect to schedule_timeout() to the 
> schedule_timeout_interruptible() helper only - so only an API 
> consolidation to improve readability. The hard coded timeout of 10
> jiffies is HZ dependent which it should not be, so it is converted
> with msecs_to_jiffies.
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m
> 
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> As the actually intended timeout is not documented and msecs_to_jiffies
> timeouts can be a factor 10 different from the current effective timeout
> this needs to be checked by someone who knows the details of this driver
> in any case it should be passed in a HZ independent manner.

I need an ack from the maintainers before I can take this.

thanks,

greg k-h

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

[Ben Romer]

>> As the actually intended timeout is not documented and msecs_to_jiffies
>> timeouts can be a factor 10 different from the current effective timeout
>> this needs to be checked by someone who knows the details of this driver
>> in any case it should be passed in a HZ independent manner.
>
> I need an ack from the maintainers before I can take this.
>
> thanks,
>
> greg k-h
>

This looks okay to me and applies cleanly to the end of our v4 series, 
so could you please apply it after the end of the v4 patch series I just 
sent? :)

Thanks!!

-- Ben

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>