From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757838AbbEaBf7 (ORCPT ); Sat, 30 May 2015 21:35:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38843 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbbEaBfx (ORCPT ); Sat, 30 May 2015 21:35:53 -0400 Date: Sun, 31 May 2015 10:18:04 +0900 From: Greg Kroah-Hartman To: Nicholas Mc Guire Cc: Benjamin Romer , Prarit Bhargava , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: use schedule_timeout_interruptible() Message-ID: <20150531011804.GA13096@kroah.com> References: <1432913476-20517-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432913476-20517-1-git-send-email-hofrat@osadl.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion with respect to schedule_timeout() to the > schedule_timeout_interruptible() helper only - so only an API > consolidation to improve readability. The hard coded timeout of 10 > jiffies is HZ dependent which it should not be, so it is converted > with msecs_to_jiffies. > > Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, > CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m > > Patch is against 4.1-rc5 (localversion-next is -next-20150529) > > Signed-off-by: Nicholas Mc Guire > --- > > As the actually intended timeout is not documented and msecs_to_jiffies > timeouts can be a factor 10 different from the current effective timeout > this needs to be checked by someone who knows the details of this driver > in any case it should be passed in a HZ independent manner. I need an ack from the maintainers before I can take this. thanks, greg k-h