From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757997AbbEaBgK (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 May 2015 21:36:10 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:38848 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757893AbbEaBgF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 May 2015 21:36:05 -0400
Date: Sun, 31 May 2015 10:19:26 +0900
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Ian Abbott <abbotti@mev.co.uk>, devel@driverdev.osuosl.org,
        Davidlohr Bueso <dave@stgolabs.net>, linux-kernel@vger.kernel.org,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Nicholas Mc Guire <hofrat@osadl.org>
Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()
Message-ID: <20150531011926.GB13096@kroah.com>
References: <1432915098-27097-1-git-send-email-hofrat@osadl.org>
 <55689582.1000700@mev.co.uk>
 <20150529164728.GA11892@opentech.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150529164728.GA11892@opentech.at>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 29, 2015 at 06:47:28PM +0200, Nicholas Mc Guire wrote:
> On Fri, 29 May 2015, Ian Abbott wrote:
> 
> > On 29/05/15 16:58, Nicholas Mc Guire wrote:
> >> API consolidation with coccinelle found:
> >> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
> >>          consolidation with schedule_timeout_*() recommended
> >>
> >> This is a 1:1 conversion of the current calls to an available helper
> >> only - so only an API consolidation to improve readability.
> >>
> >> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> >> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
> >>
> >> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> >
> > Minor niggle: you don't really need to say what version the patch is  
> > against in the commit message, as the version will have changed by the  
> > time the patch is committed.  It can be mentioned after the "---" marker  
> > line if relevant, as the stuff after the "---" line does not end up in  
> > the commit message.
> >
> makes sense - will move that down for the other cleanups.

Please fix up and resend so I don't have to hand-edit the patch.

thanks,

greg k-h