From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757969AbbEaCKC (ORCPT ); Sat, 30 May 2015 22:10:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39103 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757897AbbEaCJy (ORCPT ); Sat, 30 May 2015 22:09:54 -0400 Date: Sun, 31 May 2015 10:37:19 +0900 From: Greg KH To: Pedro Marzo Perez Cc: navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 v3] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null Message-ID: <20150531013719.GD28154@kroah.com> References: <1431991944-16924-1-git-send-email-marzo.pedro@gmail.com> <1431991944-16924-3-git-send-email-marzo.pedro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431991944-16924-3-git-send-email-marzo.pedro@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 01:32:23AM +0200, Pedro Marzo Perez wrote: > Removed two lines at ieee80211_wep_null which checkpatch.pl reported as errors. > The first one because it has a C99 comment style and the second one because it is a void > return which is useless. > > Signed-off-by: Pedro Marzo Perez > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > index 388ed3c..2ce7b54 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > @@ -289,6 +289,4 @@ void __exit ieee80211_crypto_wep_exit(void) > > void ieee80211_wep_null(void) > { > -// printk("============>%s()\n", __func__); > - return; > } You now have a function that does nothing, why not just delete it entirely?