From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Dhere, Chaitanya (C.)" <cvijaydh@visteon.com>
Cc: "cristina.opriceana@gmail.com" <cristina.opriceana@gmail.com>,
"hamohammed.sa@gmail.com" <hamohammed.sa@gmail.com>,
"gdonald@gmail.com" <gdonald@gmail.com>,
"mahfouz.saif.elyazal@gmail.com" <mahfouz.saif.elyazal@gmail.com>,
"benoit.taine@lip6.fr" <benoit.taine@lip6.fr>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions
Date: Sun, 31 May 2015 10:38:18 +0900 [thread overview]
Message-ID: <20150531013818.GE28154@kroah.com> (raw)
In-Reply-To: <20150519165543.GA2801@chaitanya-Ideapad-Z560>
On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> In this patch:
> 1. the if condition is modified to remove
> the unnecessary equality check.
> 2. The else if condition is replaced by an else condition
> since the variable checked in the if statement is a bool
> making the else if unnecessary.
> 3. Fixed indentation problem on line 1369.
> These changes were detected with help of coccinelle tool.
3 different things means you need to send 3 different patches. Please
only do one logical thing per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-31 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 16:55 [PATCH] staging: rtl8192u: Patch to modify if, else conditions Dhere, Chaitanya (C.)
2015-05-31 1:38 ` gregkh [this message]
2015-06-01 5:40 ` Dhere, Chaitanya (C.)
2015-06-02 5:13 ` Dhere, Chaitanya (C.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531013818.GE28154@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benoit.taine@lip6.fr \
--cc=cristina.opriceana@gmail.com \
--cc=cvijaydh@visteon.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox