[PATCH] staging: Replace kzalloc and memcpy by kmemdup

[PATCH] staging: Replace kzalloc and memcpy by kmemdup

[Dumbre, Nitesh Dilip (N.)]

This patch was generated by coccicheck and replaces kzalloc followed
by memcpy with kmemdup

Signed-off-by: Nitesh Dumbre <ndumbre@visteon.com>

diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 57c6ddd..c988be4 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1711,13 +1711,12 @@ int lprocfs_exp_setup(struct obd_export *exp, lnet_nid_t *nid, int *newnid)
 		goto destroy_new;
 	}
 	/* not found - create */
-	buffer = kzalloc(LNET_NIDSTR_SIZE, GFP_NOFS);
+	buffer = kmemdup(libcfs_nid2str(*nid), LNET_NIDSTR_SIZE, GFP_NOFS);
 	if (buffer == NULL) {
 		rc = -ENOMEM;
 		goto destroy_new;
 	}
 
-	memcpy(buffer, libcfs_nid2str(*nid), LNET_NIDSTR_SIZE);
 	new_stat->nid_proc = lprocfs_register(buffer,
 					      obd->obd_proc_exports_entry,
 					      NULL, NULL);
-- 
1.7.9.5

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

[Drokin, Oleg]

Thanks!
But rather than that, this whole function (lprocfs_exp_setup) needs to go, since it's not used by anything on the client.
The removal is sitting in my queue of "stop using procfs in lustre" patches that I am going to submit real soon now and this patch would just create
an unnecessary conflict.

On May 20, 2015, at 3:04 AM, Dumbre, Nitesh Dilip (N.) wrote:

> This patch was generated by coccicheck and replaces kzalloc followed
> by memcpy with kmemdup
> 
> Signed-off-by: Nitesh Dumbre <ndumbre@visteon.com>
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index 57c6ddd..c988be4 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -1711,13 +1711,12 @@ int lprocfs_exp_setup(struct obd_export *exp, lnet_nid_t *nid, int *newnid)
> 		goto destroy_new;
> 	}
> 	/* not found - create */
> -	buffer = kzalloc(LNET_NIDSTR_SIZE, GFP_NOFS);
> +	buffer = kmemdup(libcfs_nid2str(*nid), LNET_NIDSTR_SIZE, GFP_NOFS);
> 	if (buffer == NULL) {
> 		rc = -ENOMEM;
> 		goto destroy_new;
> 	}
> 
> -	memcpy(buffer, libcfs_nid2str(*nid), LNET_NIDSTR_SIZE);
> 	new_stat->nid_proc = lprocfs_register(buffer,
> 					      obd->obd_proc_exports_entry,
> 					      NULL, NULL);
> -- 
> 1.7.9.5

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

[gregkh]

On Wed, May 20, 2015 at 07:04:27AM +0000, Dumbre, Nitesh Dilip (N.) wrote:
> This patch was generated by coccicheck and replaces kzalloc followed
> by memcpy with kmemdup
> 
> Signed-off-by: Nitesh Dumbre <ndumbre@visteon.com>

Name doesn't match the From: line, please fix your broken email client.

WHat is up with this company's email, there is a bunch of patches from
different people, all of them broken like this.

greg k-h

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

[Joe Perches]

On Sun, 2015-05-31 at 11:35 +0900, gregkh@linuxfoundation.org wrote:
> On Wed, May 20, 2015 at 07:04:27AM +0000, Dumbre, Nitesh Dilip (N.) wrote:
> > This patch was generated by coccicheck and replaces kzalloc followed
> > by memcpy with kmemdup
> > 
> > Signed-off-by: Nitesh Dumbre <ndumbre@visteon.com>
> 
> Name doesn't match the From: line, please fix your broken email client.
> 
> WHat is up with this company's email, there is a bunch of patches from
> different people, all of them broken like this.

Greg you are being a bit silly here.

The names match, but the company's email naming
policy is not "first last" but "last, first".

People generally sign their names "first last".

Nothing is broken but your desire for exact name
matching.

If this was an actual "From:" line in the body of
the email, you'd be more likely correct that the
names don't match, but this is not that case.

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

[gregkh]

On Sun, May 31, 2015 at 06:13:00AM -0700, Joe Perches wrote:
> On Sun, 2015-05-31 at 11:35 +0900, gregkh@linuxfoundation.org wrote:
> > On Wed, May 20, 2015 at 07:04:27AM +0000, Dumbre, Nitesh Dilip (N.) wrote:
> > > This patch was generated by coccicheck and replaces kzalloc followed
> > > by memcpy with kmemdup
> > > 
> > > Signed-off-by: Nitesh Dumbre <ndumbre@visteon.com>
> > 
> > Name doesn't match the From: line, please fix your broken email client.
> > 
> > WHat is up with this company's email, there is a bunch of patches from
> > different people, all of them broken like this.
> 
> Greg you are being a bit silly here.
> 
> The names match, but the company's email naming
> policy is not "first last" but "last, first".
> 
> People generally sign their names "first last".
> 
> Nothing is broken but your desire for exact name
> matching.

There's also an odd "(H)." in the From line as well.

And yes, I do desire that as I know all about the tools we have that try
to check these things (numbers of developers, etc.) and some of them
don't like mismatched names.

Also, it's good for people to learn about "From:" in the body of the
email, that's what it is there for :)

thanks,

greg k-h