From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756495AbbEaFyp (ORCPT ); Sun, 31 May 2015 01:54:45 -0400 Received: from hofr.at ([212.69.189.236]:58472 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbEaFyh (ORCPT ); Sun, 31 May 2015 01:54:37 -0400 Date: Sun, 31 May 2015 07:54:34 +0200 From: Nicholas Mc Guire To: Greg Kroah-Hartman Cc: Nicholas Mc Guire , Lidza Louina , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible() Message-ID: <20150531055434.GA7529@opentech.at> References: <1432917688-20228-1-git-send-email-hofrat@osadl.org> <20150531012556.GC13096@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150531012556.GC13096@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 May 2015, Greg Kroah-Hartman wrote: > On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote: > > API consolidation with coccinelle found: > > ./drivers/staging/dgnc/dgnc_utils.c:16:1-17: > > consolidation with schedule_timeout_*() recommended > > > > This is a 1:1 conversion with respect to schedule_timeout() to the > > schedule_timeout_interruptible() helper only - so only an API > > consolidation to improve readability. The timeout was being passed > > as (ms * HZ) / 1000 but that is not reliable as it allows the timeout > > to become 0 for small values of ms. As this cut-off is HZ dependent > > this is most likely not intended, so the timeout is converted with > > msecs_to_jiffies which handles all corener-cases correctly. > > > > Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, > > CONFIG_DGNC=m > > > > Patch is against 4.1-rc5 (localversion-next is -next-20150529) > > Can you resend this without these two sentances? They are not needed > and are just "implied" as you should have done this for every patch > submitted. The config does allow for some level of variantion (e.g. what hardware it was compile tested for) and also if it was a module or built-in. I originally put this below the "---" until I was explicitly ast to put it above http://lkml.org/lkml/2015/5/11/552 will fix it up and resend. thx! hofrat