Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, May 31, 2015 at 07:54:34AM +0200, Nicholas Mc Guire wrote:
> On Sun, 31 May 2015, Greg Kroah-Hartman wrote:
> 
> > On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote:
> > > API consolidation with coccinelle found:
> > > ./drivers/staging/dgnc/dgnc_utils.c:16:1-17:
> > >         consolidation with schedule_timeout_*() recommended
> > > 
> > > This is a 1:1 conversion with respect to schedule_timeout() to the
> > > schedule_timeout_interruptible() helper only - so only an API
> > > consolidation to improve readability. The timeout was being passed
> > > as (ms * HZ) / 1000 but that is not reliable as it allows the timeout
> > > to become 0 for small values of ms. As this cut-off is HZ dependent
> > > this is most likely not intended, so the timeout is converted with 
> > > msecs_to_jiffies which handles all corener-cases correctly.
> > > 
> > > Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> > > CONFIG_DGNC=m
> > > 
> > > Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> > 
> > Can you resend this without these two sentances?  They are not needed
> > and are just "implied" as you should have done this for every patch
> > submitted.
> 
> The config does allow for some level of variantion (e.g. what hardware
> it was compile tested for) and also if it was a module or built-in.
> 
> I originally put this below the "---" until I was explicitly ast to put 
> it above http://lkml.org/lkml/2015/5/11/552

Josh is a maintainer of a subsystem that gets a handful of patches a
release, at the most, he can carefully hand edit them all with no hit to
his productivity.  Me, I deal with a few thousand a release :)

And he's right about the tools, just not the fact of what branch you
made it against, or that you actually test built the thing, those are
not useful things in the changelog to preserve for forever as they don't
help anyone out.

thanks,

greg k-h