From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758219AbbEaGyn (ORCPT ); Sun, 31 May 2015 02:54:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758029AbbEaGye (ORCPT ); Sun, 31 May 2015 02:54:34 -0400 Date: Sun, 31 May 2015 15:48:59 +0900 From: Greg KH To: Nikhil Badola Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller Message-ID: <20150531064859.GA17795@kroah.com> References: <1432640682-18555-1-git-send-email-nikhil.badola@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432640682-18555-1-git-send-email-nikhil.badola@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 05:14:42PM +0530, Nikhil Badola wrote: > Check IP version 2.4 for multi port host USB controller and > return FSL_USB_VER_2_4 macro > > Signed-off-by: Nikhil Badola > --- > Separate patches clubbed and resent in an ordered patchset > with proper mailing list in cc > > drivers/usb/host/fsl-mph-dr-of.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c > index 7e325e9..e588ccd 100644 > --- a/drivers/usb/host/fsl-mph-dr-of.c > +++ b/drivers/usb/host/fsl-mph-dr-of.c > @@ -126,6 +126,7 @@ static int usb_get_ver_info(struct device_node *np) > /* > * returns 1 for usb controller version 1.6 > * returns 2 for usb controller version 2.2 > + * returns 3 for usb controller version 2.4 > * returns 0 otherwise Shouldn't the comment use the #define names instead of values? You can do that in a later patch. thanks, greg k-h