* [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller
@ 2015-05-26 11:44 Nikhil Badola
2015-05-31 6:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Badola @ 2015-05-26 11:44 UTC (permalink / raw)
To: linux-kernel; +Cc: stern, gregkh, linux-usb, Nikhil Badola
Check IP version 2.4 for multi port host USB controller and
return FSL_USB_VER_2_4 macro
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
Separate patches clubbed and resent in an ordered patchset
with proper mailing list in cc
drivers/usb/host/fsl-mph-dr-of.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 7e325e9..e588ccd 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -126,6 +126,7 @@ static int usb_get_ver_info(struct device_node *np)
/*
* returns 1 for usb controller version 1.6
* returns 2 for usb controller version 2.2
+ * returns 3 for usb controller version 2.4
* returns 0 otherwise
*/
if (of_device_is_compatible(np, "fsl-usb2-dr")) {
@@ -150,6 +151,8 @@ static int usb_get_ver_info(struct device_node *np)
ver = FSL_USB_VER_1_6;
else if (of_device_is_compatible(np, "fsl-usb2-mph-v2.2"))
ver = FSL_USB_VER_2_2;
+ else if (of_device_is_compatible(np, "fsl-usb2-mph-v2.4"))
+ ver = FSL_USB_VER_2_4;
else /* for previous controller versions */
ver = FSL_USB_VER_OLD;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller
2015-05-26 11:44 [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller Nikhil Badola
@ 2015-05-31 6:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-05-31 6:48 UTC (permalink / raw)
To: Nikhil Badola; +Cc: linux-kernel, stern, linux-usb
On Tue, May 26, 2015 at 05:14:42PM +0530, Nikhil Badola wrote:
> Check IP version 2.4 for multi port host USB controller and
> return FSL_USB_VER_2_4 macro
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Separate patches clubbed and resent in an ordered patchset
> with proper mailing list in cc
>
> drivers/usb/host/fsl-mph-dr-of.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..e588ccd 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -126,6 +126,7 @@ static int usb_get_ver_info(struct device_node *np)
> /*
> * returns 1 for usb controller version 1.6
> * returns 2 for usb controller version 2.2
> + * returns 3 for usb controller version 2.4
> * returns 0 otherwise
Shouldn't the comment use the #define names instead of values?
You can do that in a later patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-31 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-26 11:44 [PATCH 1/5] drivers:usb:fsl: Check IP version 2.4 for mph USB controller Nikhil Badola
2015-05-31 6:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox