From: Greg KH <gregkh@linuxfoundation.org>
To: Nikhil Badola <nikhil.badola@freescale.com>
Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type
Date: Sun, 31 May 2015 16:13:23 +0900 [thread overview]
Message-ID: <20150531071323.GA31243@kroah.com> (raw)
In-Reply-To: <1432640748-18657-1-git-send-email-nikhil.badola@freescale.com>
On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote:
> Replace macros with enumerated type to represent usb ip
> controller version
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> include/linux/fsl_devices.h | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> index 2a2f56b..6447b7b 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -20,11 +20,6 @@
> #define FSL_UTMI_PHY_DLY 10 /*As per P1010RM, delay for UTMI
> PHY CLK to become stable - 10ms*/
> #define FSL_USB_PHY_CLK_TIMEOUT 10000 /* uSec */
> -#define FSL_USB_VER_OLD 0
> -#define FSL_USB_VER_1_6 1
> -#define FSL_USB_VER_2_2 2
> -#define FSL_USB_VER_2_4 3
> -#define FSL_USB_VER_2_5 4
>
> #include <linux/types.h>
>
> @@ -52,6 +47,14 @@
> *
> */
>
> +enum fsl_usb2_controller_ver {
> + FSL_USB_VER_OLD = 0,
> + FSL_USB_VER_1_6,
> + FSL_USB_VER_2_2,
> + FSL_USB_VER_2_4,
> + FSL_USB_VER_2_5,
> +};
I applied the first 2 patches here, can you please fix this up and
resend the rest?
thanks,
greg k-h
prev parent reply other threads:[~2015-05-31 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 11:45 [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type Nikhil Badola
2015-05-31 6:50 ` Greg KH
2015-05-31 7:11 ` Joe Perches
2015-05-31 21:01 ` Greg KH
2015-06-01 6:19 ` Badola Nikhil
2015-06-04 4:05 ` Badola Nikhil
2015-05-31 7:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531071323.GA31243@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikhil.badola@freescale.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox