From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758262AbbEaHPg (ORCPT ); Sun, 31 May 2015 03:15:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41197 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754390AbbEaHP2 (ORCPT ); Sun, 31 May 2015 03:15:28 -0400 Date: Sun, 31 May 2015 16:13:23 +0900 From: Greg KH To: Nikhil Badola Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type Message-ID: <20150531071323.GA31243@kroah.com> References: <1432640748-18657-1-git-send-email-nikhil.badola@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432640748-18657-1-git-send-email-nikhil.badola@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote: > Replace macros with enumerated type to represent usb ip > controller version > > Signed-off-by: Nikhil Badola > --- > include/linux/fsl_devices.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h > index 2a2f56b..6447b7b 100644 > --- a/include/linux/fsl_devices.h > +++ b/include/linux/fsl_devices.h > @@ -20,11 +20,6 @@ > #define FSL_UTMI_PHY_DLY 10 /*As per P1010RM, delay for UTMI > PHY CLK to become stable - 10ms*/ > #define FSL_USB_PHY_CLK_TIMEOUT 10000 /* uSec */ > -#define FSL_USB_VER_OLD 0 > -#define FSL_USB_VER_1_6 1 > -#define FSL_USB_VER_2_2 2 > -#define FSL_USB_VER_2_4 3 > -#define FSL_USB_VER_2_5 4 > > #include > > @@ -52,6 +47,14 @@ > * > */ > > +enum fsl_usb2_controller_ver { > + FSL_USB_VER_OLD = 0, > + FSL_USB_VER_1_6, > + FSL_USB_VER_2_2, > + FSL_USB_VER_2_4, > + FSL_USB_VER_2_5, > +}; I applied the first 2 patches here, can you please fix this up and resend the rest? thanks, greg k-h