[PATCH] staging: rtl8192u: Patch to modify if, else conditions

[PATCH] staging: rtl8192u: Patch to modify if, else conditions

[Dhere, Chaitanya (C.)]

In this patch:
1. the if condition is modified to remove
the unnecessary equality check.
2. The else if condition is replaced by an else condition
since the variable checked in the if statement is a bool
making the else if unnecessary.
3. Fixed indentation problem on line 1369.
These changes were detected with help of coccinelle tool.

Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12..41f74ab 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1364,12 +1364,11 @@ static void ieee80211_associate_complete_wq(struct work_struct *work)
 		ieee->LinkDetectInfo.NumRecvDataInPeriod= 1;
 	}
 	ieee->link_change(ieee->dev);
-	if(ieee->is_silent_reset == 0){
+	if (!ieee->is_silent_reset) {
 		printk("============>normal associate\n");
-	notify_wx_assoc_event(ieee);
+		notify_wx_assoc_event(ieee);
 	}
-	else if(ieee->is_silent_reset == 1)
-	{
+	else {
 		printk("==================>silent reset associate\n");
 		ieee->is_silent_reset = false;
 	}
--
1.9.1

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

[gregkh]

On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> In this patch:
> 1. the if condition is modified to remove
> the unnecessary equality check.
> 2. The else if condition is replaced by an else condition
> since the variable checked in the if statement is a bool
> making the else if unnecessary.
> 3. Fixed indentation problem on line 1369.
> These changes were detected with help of coccinelle tool.

3 different things means you need to send 3 different patches.  Please
only do one logical thing per patch.

thanks,

greg k-h

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

[Dhere, Chaitanya (C.)]

On Sun, May 31, 2015 at 10:38:18AM +0900, gregkh@linuxfoundation.org wrote:
> On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> > In this patch:
> > 1. the if condition is modified to remove
> > the unnecessary equality check.
> > 2. The else if condition is replaced by an else condition
> > since the variable checked in the if statement is a bool
> > making the else if unnecessary.
> > 3. Fixed indentation problem on line 1369.
> > These changes were detected with help of coccinelle tool.
> 
> 3 different things means you need to send 3 different patches.  Please
> only do one logical thing per patch.
> 
> thanks,
> 
> greg k-h

Ok Greg I will send a V2 of my patch split into 3 patches

Thanks,
Chaitanya Dhere

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

[Dhere, Chaitanya (C.)]

On Sun, May 31, 2015 at 10:38:18AM +0900, gregkh@linuxfoundation.org wrote:
> On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> > In this patch:
> > 1. the if condition is modified to remove
> > the unnecessary equality check.
> > 2. The else if condition is replaced by an else condition
> > since the variable checked in the if statement is a bool
> > making the else if unnecessary.
> > 3. Fixed indentation problem on line 1369.
> > These changes were detected with help of coccinelle tool.
> 
> 3 different things means you need to send 3 different patches.  Please
> only do one logical thing per patch.
> 
> thanks,
> 
> greg k-h

Hello,
      I will make the correction in subject and resend the patch

Thanks,
chaitanya