From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751030AbbFAJVg (ORCPT ); Mon, 1 Jun 2015 05:21:36 -0400 Received: from 8bytes.org ([81.169.241.247]:49697 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbbFAJV0 (ORCPT ); Mon, 1 Jun 2015 05:21:26 -0400 Date: Mon, 1 Jun 2015 11:21:24 +0200 From: Joerg Roedel To: Baoquan He Cc: linux-kernel@vger.kernel.org Subject: Re: A question about state machine function state_next() Message-ID: <20150601092124.GD20384@8bytes.org> References: <20150601030940.GK6353@dhcp-128-28.nay.redhat.com> <20150601064238.GC20384@8bytes.org> <20150601090902.GA31271@dhcp-128-28.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150601090902.GA31271@dhcp-128-28.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baoquan, On Mon, Jun 01, 2015 at 05:09:02PM +0800, Baoquan He wrote: > Then I am wondering how amd_iommu_dma_ops is assigned. Maybe I need > check all functions more clearly. The AMD IOMMU driver only uses per-device dma_ops. They are assigned to each device in device_dma_ops_init() at boot and in the device_change_notifier() on hotplug events. > Actually I am investigating how to port Zhenhua's kdump fix for intel > iommu to amd iommu since the similar bug happened on systems with amd > iommu. If you don't mind I can make these clean up during I understand > these iommu codes. And if Zhenhua plan to post patch for amd fix, I > can help review and test. Otherwise I can make some research and try > to post a draft patch. Thanks for looking into this. Unfortunatly this somehow conflicts with my recent default-domain patch-set, which moves functionality into the IOMMU core and converts the AMD driver to make use of it. I have no real idea yet how to make both work, but it shouldn't be too hard. Maybe you can have a look into that patch-set too? Joerg