From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbbFANH7 (ORCPT ); Mon, 1 Jun 2015 09:07:59 -0400 Received: from one.firstfloor.org ([193.170.194.197]:40645 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752886AbbFANHD (ORCPT ); Mon, 1 Jun 2015 09:07:03 -0400 Date: Mon, 1 Jun 2015 15:07:00 +0200 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 04/10] perf, tools, report: Add processing for cycle histograms Message-ID: <20150601130700.GC19417@two.firstfloor.org> References: <1431265926-4766-1-git-send-email-andi@firstfloor.org> <1431265926-4766-5-git-send-email-andi@firstfloor.org> <20150526100912.GE6555@krava.brq.redhat.com> <20150526173730.GP19417@two.firstfloor.org> <20150601130223.GA9846@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150601130223.GA9846@krava.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2015 at 03:02:23PM +0200, Jiri Olsa wrote: > On Tue, May 26, 2015 at 07:37:30PM +0200, Andi Kleen wrote: > > > hum, so this is assuming that having cycles fort 1st entry > > > means there'll be for the rest? > > > Also in that case why is there the '!= cycles' check within > > > addr_map_symbol__account_cycles ? > > > > > It means there might be. It's just a short cut. But rarely > > branches may still have 0 cycles, so it still needs to be > > checked later. > > > > In theory it could miss a valid one if the first happened > > to be zero, but that seems very unlikely. > > so having 'bs->entries[0].flags.cycles' is the only way > of knowing that we have the feature enabled? Yes. In theory we could add caps in sysfs like the PT code, but that's not implemented currently. -Andi -- ak@linux.intel.com -- Speaking for myself only.