Re: Cycles annotation support for perf tools v2

[Jiri Olsa <jolsa@redhat.com>]

On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote:
> [v2: Addressed review comments. Fixed display problems and 
> correctly compute IPC now. See patches for detailed changes.]
> 
> The upcoming Skylake CPU has a new timed branch stack feature,
> that reports cycle counts for individual branches in the
> last branch record.
> 
> This allows to get fine grained cost information for code, and also allows
> to compute fine grained IPC.
> 
> Available from
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/skl-tools2
> 
> This patchkit adds support for this in the perf tools:
> - Basic support for the cycles field like other branch fields
> - Show cycles in the standard branch sort view (no IPC here,
>   as IPC needs the instruction counts from annotation)
> - Annotate cycles and IPC in the assembler annotate view
> - Add branch support to top, so we can do live annotation.
> - Misc support, like dumping it in perf report -D

v2 seems ok to me.. all my comments were addressed,
and I posted one more comment

anyway, I dont touch annotate code that much to ack annotate
core patches.. acking only portion of the patchset

thanks,
jirka