From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752758AbbFAOmq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2015 10:42:46 -0400
Received: from mail-la0-f43.google.com ([209.85.215.43]:33513 "EHLO
	mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751176AbbFAOmg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2015 10:42:36 -0400
Date: Mon, 1 Jun 2015 16:42:38 +0200
From: Johan Hovold <johan@kernel.org>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Julia Lawall <julia.lawall@lip6.fr>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: Use setup_timer
Message-ID: <20150601144238.GH27360@localhost>
References: <20150601011157.GA5631@vaishali-Ideapad-Z570>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150601011157.GA5631@vaishali-Ideapad-Z570>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 01, 2015 at 06:41:57AM +0530, Vaishali Thakkar wrote:
> Use the timer API function setup_timer instead of structure field
> assignments to initialize a timer.
> 
> A simplified version of the Coccinelle semantic patch that performs
> this transformation is as follows:
> 
> @change@
> expression e1, e2, e3, e4, a, b;
> @@
> 
> -init_timer(&e1);
> +setup_timer(&e1, a, b);
> 
> ... when != a = e2
>     when != b = e3
> 
> -e1.function = a;
> ... when != b = e4
> -e1.data = b;
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>

Applied with a slightly modified summary adding "mos7840" as this patch
only touches that driver.

Thanks,
Johan