* watchdog: st_wdt: select on undefined MFD_ST_LPC
@ 2015-06-01 15:09 Valentin Rothberg
2015-06-01 17:55 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2015-06-01 15:09 UTC (permalink / raw)
To: lee.jones
Cc: Valentin Rothberg, Andreas Ruprecht, Paul Bolle, hengelein Stefan,
wim, david.paris, linux-kernel, linux-watchdog
Hi Lee,
your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
adds the following lines of code to drivers/watchdog/Kconfig.
+config ST_LPC_WATCHDOG
...
+ select MFD_ST_LPC
The select turns out to be a NOOP since MFD_ST_LPC is not defined
Kconfig. Is it the correct option to be selected? I could not find a
similar option in the source, nor get any hints from searching the
lkml.
I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
the last and today's linux tree.
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: watchdog: st_wdt: select on undefined MFD_ST_LPC
2015-06-01 15:09 watchdog: st_wdt: select on undefined MFD_ST_LPC Valentin Rothberg
@ 2015-06-01 17:55 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-06-01 17:55 UTC (permalink / raw)
To: Valentin Rothberg
Cc: Andreas Ruprecht, Paul Bolle, hengelein Stefan, wim, david.paris,
linux-kernel, linux-watchdog
On Mon, 01 Jun 2015, Valentin Rothberg wrote:
> Hi Lee,
>
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
>
> +config ST_LPC_WATCHDOG
> ...
> + select MFD_ST_LPC
>
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig. Is it the correct option to be selected? I could not find a
> similar option in the source, nor get any hints from searching the
> lkml.
>
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.
You're right. This symbol is legacy. I will remove.
Thanks for reporting.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-01 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-01 15:09 watchdog: st_wdt: select on undefined MFD_ST_LPC Valentin Rothberg
2015-06-01 17:55 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox