From: Ralf Baechle <ralf@linux-mips.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Andreas Ruprecht <andreas.ruprecht@fau.de>,
hengelein Stefan <stefan.hengelein@fau.de>,
tglx@linutronix.de, jason@lakedaemon.net,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: MIPS/IRQCHIP: some remainders of IRQ_CPU
Date: Mon, 1 Jun 2015 21:53:39 +0200 [thread overview]
Message-ID: <20150601195339.GB29986@linux-mips.org> (raw)
In-Reply-To: <CAD3Xx4K_qq-FZPymp4Ss7rG2FC4iK3TF1sJnBMO+7haMFN_wFg@mail.gmail.com>
On Mon, Jun 01, 2015 at 04:51:48PM +0200, Valentin Rothberg wrote:
> Hi Ralf,
>
> your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
> to drivers/irqchip.") is in today's linux-next tree (i.e.,
> next-20150601). It renames the Kconfig option IRQ_CPU to
> IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git
> grep) in arch/mips.
>
> If you agree, I can send a trivial patch that renames those remainders?
sed -i -e 's@\bIRQ_CPU\b@IRQ_MIPS_CPU@' $(git grep -l -w IRQ_CPU)
or something like that.
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.
>
> Some advertisement for a small tool I started a few month a go, which
> is made for such cases. With vgrep [1] you can grep for symbols in
> the current directory tree and afterwards open specific lines in your
> editor. It's more or less a comfortable wrapper around (git) grep. I
> use it a lot to study source code as well as to manage code changes.
> The most prominent user I know is Greg KH who uses it as a replacement
> for cgvg.
>
> Kind regards,
> Valentin
>
> [1] https://github.com/vrothberg/vgrep
Thanks for reporting!
Ralf
next prev parent reply other threads:[~2015-06-01 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:51 MIPS/IRQCHIP: some remainders of IRQ_CPU Valentin Rothberg
2015-06-01 19:53 ` Ralf Baechle [this message]
2015-06-02 5:48 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601195339.GB29986@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=andreas.ruprecht@fau.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
--cc=stefan.hengelein@fau.de \
--cc=tglx@linutronix.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox