MIPS/IRQCHIP: some remainders of IRQ_CPU

MIPS/IRQCHIP: some remainders of IRQ_CPU

[Valentin Rothberg]

Hi Ralf,

your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
to drivers/irqchip.") is in today's linux-next tree (i.e.,
next-20150601).  It renames the Kconfig option IRQ_CPU to
IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git
grep) in arch/mips.

If you agree, I can send a trivial patch that renames those remainders?

I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
the last and today's linux tree.

Some advertisement for a small tool I started a few month a go, which
is made for such cases.  With vgrep [1] you can grep for symbols in
the current directory tree and afterwards open specific lines in your
editor.  It's more or less a comfortable wrapper around (git) grep.  I
use it a lot to study source code as well as to manage code changes.
The most prominent user I know is Greg KH who uses it as a replacement
for cgvg.

Kind regards,
 Valentin

[1] https://github.com/vrothberg/vgrep

Re: MIPS/IRQCHIP: some remainders of IRQ_CPU

[Ralf Baechle]

On Mon, Jun 01, 2015 at 04:51:48PM +0200, Valentin Rothberg wrote:

> Hi Ralf,
> 
> your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
> to drivers/irqchip.") is in today's linux-next tree (i.e.,
> next-20150601).  It renames the Kconfig option IRQ_CPU to
> IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git
> grep) in arch/mips.
> 
> If you agree, I can send a trivial patch that renames those remainders?

sed -i -e 's@\bIRQ_CPU\b@IRQ_MIPS_CPU@' $(git grep -l -w IRQ_CPU)

or something like that.

> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.
> 
> Some advertisement for a small tool I started a few month a go, which
> is made for such cases.  With vgrep [1] you can grep for symbols in
> the current directory tree and afterwards open specific lines in your
> editor.  It's more or less a comfortable wrapper around (git) grep.  I
> use it a lot to study source code as well as to manage code changes.
> The most prominent user I know is Greg KH who uses it as a replacement
> for cgvg.
> 
> Kind regards,
>  Valentin
> 
> [1] https://github.com/vrothberg/vgrep

Thanks for reporting!

  Ralf

Re: MIPS/IRQCHIP: some remainders of IRQ_CPU

[Valentin Rothberg]

Hi Ralf,

thanks for your answer.

On Mon, Jun 1, 2015 at 9:53 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Mon, Jun 01, 2015 at 04:51:48PM +0200, Valentin Rothberg wrote:
>
>> Hi Ralf,
>>
>> your commit 1f1786e60b53 ("MIPS/IRQCHIP: Move irq_chip from arch/mips
>> to drivers/irqchip.") is in today's linux-next tree (i.e.,
>> next-20150601).  It renames the Kconfig option IRQ_CPU to
>> IRQ_MIPS_CPU, but misses to rename a few Kconfig selects (see git
>> grep) in arch/mips.
>>
>> If you agree, I can send a trivial patch that renames those remainders?
>
> sed -i -e 's@\bIRQ_CPU\b@IRQ_MIPS_CPU@' $(git grep -l -w IRQ_CPU)
>
> or something like that.

I am not sure if you want me to send a patch, do you?

Kind regards,
 Valentin

>> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
>> the last and today's linux tree.
>>
>> Some advertisement for a small tool I started a few month a go, which
>> is made for such cases.  With vgrep [1] you can grep for symbols in
>> the current directory tree and afterwards open specific lines in your
>> editor.  It's more or less a comfortable wrapper around (git) grep.  I
>> use it a lot to study source code as well as to manage code changes.
>> The most prominent user I know is Greg KH who uses it as a replacement
>> for cgvg.
>>
>> Kind regards,
>>  Valentin
>>
>> [1] https://github.com/vrothberg/vgrep
>
> Thanks for reporting!
>
>   Ralf