From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbbFAVTR (ORCPT ); Mon, 1 Jun 2015 17:19:17 -0400 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:3899 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588AbbFAVTF (ORCPT ); Mon, 1 Jun 2015 17:19:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AGCQBcy2xVPMEeLHlcgxCBMoZMpgkBAQEBAQEGmU8CAgEBAoE2TQEBAQEBAQcBAQEBQT+EIwEBBDocMwgDGAklDwUlAwcaARKILNhNAQEIAQEBAR4YhgGFKoUNgxeBFgWeJY0fihqBBIEpHIFkLDGCRwEBAQ Date: Tue, 2 Jun 2015 07:19:02 +1000 From: Dave Chinner To: Dave Jones , Linux Kernel Subject: Re: notify_change() WARN_ON being triggered on XFS. Message-ID: <20150601211902.GD9143@dastard> References: <20150527214448.GA14089@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150527214448.GA14089@codemonkey.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 05:44:48PM -0400, Dave Jones wrote: > WARNING: CPU: 1 PID: 29887 at fs/attr.c:198 notify_change+0x2e6/0x390() > CPU: 1 PID: 29887 Comm: trinity-c13 Not tainted 4.1.0-rc5-gelk-debug+ #1 > 0000000000000009 ffff880041fb7b28 ffffffff967685f0 ffff8800bf7d12b8 > 0000000000000000 ffff880041fb7b68 ffffffff9607eaaa ffff880041fb7b58 > 0000000000000a00 ffff880073442510 000000000000888f ffff8800a61c2698 > Call Trace: > [] dump_stack+0x4f/0x7b > [] warn_slowpath_common+0x8a/0xc0 > [] warn_slowpath_null+0x1a/0x20 > [] notify_change+0x2e6/0x390 > [] file_remove_suid+0x92/0xb0 > [] ? __mnt_drop_write_file+0x12/0x20 > [] ? file_update_time+0xa8/0xf0 > [] xfs_file_aio_write_checks+0x11e/0x160 [xfs] > [] xfs_file_dio_aio_write+0xc7/0x590 [xfs] > [] ? mutex_lock_nested+0x283/0x440 > [] ? pipe_wait+0x8a/0xb0 > [] xfs_file_write_iter+0x105/0x120 [xfs] > [] vfs_iter_write+0x6d/0xa0 > [] iter_file_splice_write+0x264/0x3c0 > [] SyS_splice+0x361/0x7d0 > [] ? context_tracking_user_exit+0x13/0x20 > [] tracesys_phase2+0x84/0x89 There's a fix pending. Waiting on Al Viro to pick it up for the next merge window... Cheers, Dave. -- Dave Chinner david@fromorbit.com