From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288AbbFAXp5 (ORCPT ); Mon, 1 Jun 2015 19:45:57 -0400 Received: from mail-vn0-f48.google.com ([209.85.216.48]:35681 "EHLO mail-vn0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753911AbbFAXpq (ORCPT ); Mon, 1 Jun 2015 19:45:46 -0400 Date: Mon, 1 Jun 2015 20:44:21 -0300 From: Gaston Gonzalez To: Joe Perches Cc: gregkh@linuxfoundation.org, cristina.opriceana@gmail.com, hamohammed.sa@gmail.com, gdonald@gmail.com, mahfouz.saif.elyazal@gmail.com, paul.gortmaker@windriver.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings Message-ID: <20150601234421.GA3129@debianG> References: <1433194203-3373-1-git-send-email-gascoar@gmail.com> <1433195008.4861.53.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433195008.4861.53.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2015 at 02:43:28PM -0700, Joe Perches wrote: > On Mon, 2015-06-01 at 18:30 -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > [] > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > [] > > @@ -660,8 +660,9 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be > > auth = (struct ieee80211_authentication *) > > skb_put(skb, sizeof(struct ieee80211_authentication)); > > > > - auth->header.frame_ctl = IEEE80211_STYPE_AUTH; > > - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP; > > + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH); > > + if (challengelen) > > + auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP); > > It'd be better to use normal tab indentation and likely > it'd also be better to set this only once > > if (challengelen) > auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP); > else > auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH); > > or maybe a single line > > auth->header.frame_ctl = cpu_to_le16(challengelen ? IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP : IEEE80211_STYPE_AUTH); > > though I think the first is simpler to read. > > Thanks for the feedback. I'll send a v2 making the changes according to your first option. regards, Gaston