From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbbFBEul (ORCPT ); Tue, 2 Jun 2015 00:50:41 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36106 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbFBEuc (ORCPT ); Tue, 2 Jun 2015 00:50:32 -0400 Date: Tue, 2 Jun 2015 10:20:26 +0530 From: Viresh Kumar To: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nishanth Menon , Srinivas Kandagatla , Andy Gross , linux-pm@vger.kernel.org, Mark Brown , David Collins Subject: Re: [PATCH 3/6] PM / OPP: Support adjusting OPP voltages at runtime Message-ID: <20150602045026.GC10443@linux> References: <1433209679-31389-1-git-send-email-sboyd@codeaurora.org> <1433209679-31389-4-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433209679-31389-4-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-06-15, 18:47, Stephen Boyd wrote: > +int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq, > + unsigned long u_volt); > +static inline int dev_pm_opp_adjust_voltage(struct device *dev, > + unsigned long freq, unsigned long u_volt) The 'u' of 'unsigned' isn't aligned to the opening curly brace. Try running with checkpatch --strict and you will see some warnings. Otherwise, Acked-by: Viresh Kumar -- viresh