Re: [PATCH v3 00/12] wilc1000: dead code removal and other cleanup

Greg KH
2015-06-02T05:20:36Z

On Tue, Jun 02, 2015 at 01:53:31PM +0900, Greg KH wrote:
> On Mon, Jun 01, 2015 at 09:06:33PM +0200, Arnd Bergmann wrote:
> > Hi Greg,
> >
> > Next try, I've rebased on top of your staging-testing branch
> > and fixed the two build errors.
> >
> > While I had done my normal build testing on the driver (a few
> > hundred randconfig builds), I don't normally do 'make clean',
> > so the stale Makefile entry ended up picking the old object
> > files and succeeding with that.
>
> Thanks, I've applied these but there are still a bunch of warnings.
> It's obvious no one has ever built this code on a 64bit processor
> (Atmel, come on, not all the world is 32bits...)
>
> I'll take a pass at it to see if I can clean up some stuff to maybe
> reduce the number of warnings, but right now, it's still way too many
> for linux-next to want to enable as it blows up their logs...

Ugh, that's a rabbit hole you can disappear into for a long time. I did
a few patches but ran out of time, I can spend days mucking down in
there unwinding the mess...

Johnny, Rachel, Dean, and Chris, can you all fix up all of the build
warnings as soon as possible? Take my tree and work off of that, just
build it on your desktop 64bit Linux build and get rid of all of them
properly and send me the patches. Hopefully by the end of this week so
that linux-next can get some testing with this driver enabled.

thanks,

greg k-h