From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: gregkh@linuxfoundation.org, joe@perches.com,
devel@driverdev.osuosl.org, hamohammed.sa@gmail.com,
gdonald@gmail.com, linux-kernel@vger.kernel.org,
paul.gortmaker@windriver.com, cristina.opriceana@gmail.com
Subject: Re: [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings
Date: Tue, 2 Jun 2015 11:09:41 +0530 [thread overview]
Message-ID: <20150602053941.GA6382@sudip-PC> (raw)
In-Reply-To: <1433205811-21227-1-git-send-email-gascoar@gmail.com>
On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote:
> Fix the following sparse warnings:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d2e8b12..d0a6a59 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -660,8 +660,10 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
> auth = (struct ieee80211_authentication *)
> skb_put(skb, sizeof(struct ieee80211_authentication));
>
> - auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> + if (challengelen)
> + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP);
it is introducing new checkpatch warning of "line over 80 characters".
regards
sudip
next prev parent reply other threads:[~2015-06-02 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 0:43 [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings Gaston Gonzalez
2015-06-02 5:39 ` Sudip Mukherjee [this message]
2015-06-02 14:39 ` Gaston Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602053941.GA6382@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gascoar@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox