From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbbFBG0G (ORCPT ); Tue, 2 Jun 2015 02:26:06 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:35472 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbbFBGZ5 (ORCPT ); Tue, 2 Jun 2015 02:25:57 -0400 Date: Tue, 2 Jun 2015 11:55:50 +0530 From: Sudip Mukherjee To: Isaac Assegai Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] Staging: sm750fb: sm750.h: Insert spaces after commas. Message-ID: <20150602062550.GD6382@sudip-PC> References: <1433134873-9869-1-git-send-email-isaac.a.travers@gmail.com> <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 31, 2015 at 10:01:04PM -0700, Isaac Assegai wrote: > Insert Spaces after commas to rectify the > following checkpatch errors in sm750.h: > ERROR: space required after that ',' > > Signed-off-by: Isaac Assegai > --- > drivers/staging/sm750fb/sm750.h | 35 ++++++++++++++++++----------------- > 1 file changed, 18 insertions(+), 17 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index 5528912..5f86077 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -12,7 +12,7 @@ > #define MB(x) ((x)<<20) > #define MHZ(x) ((x) * 1000000) > /* align should be 2,4,8,16 */ > -#define PADDING(align,data) (((data)+(align)-1)&(~((align) -1))) > +#define PADDING(align, data) (((data)+(align)-1)&(~((align) -1))) > extern int smi_indent; > > > @@ -27,15 +27,16 @@ struct lynx_accel{ > > > - int (*de_imageblit)(struct lynx_accel *,const char *,u32,u32,u32, > - u32,u32,u32,u32,u32,u32,u32,u32,u32); > + int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32, ^^^^^ oops, trailing whitespace errors :( > + u32, u32, u32, u32, ^^^^^ here also please test your patch with checkpatch before sending regards sudip