From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756016AbbFBIuP (ORCPT ); Tue, 2 Jun 2015 04:50:15 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35229 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754399AbbFBItp (ORCPT ); Tue, 2 Jun 2015 04:49:45 -0400 Date: Tue, 2 Jun 2015 10:49:39 +0200 From: Ingo Molnar To: Alexander Popov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrey Ryabinin , Andrey Konovalov , Andrew Morton , Kees Cook , "Peter Zijlstra (Intel)" , Andy Lutomirski , Alexander Kuleshov , Borislav Petkov , Denys Vlasenko , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] x86_64: fix KASan shadow region page tables Message-ID: <20150602084939.GA412@gmail.com> References: <1432919222-3685-1-git-send-email-alpopov@ptsecurity.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432919222-3685-1-git-send-email-alpopov@ptsecurity.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexander Popov wrote: > KASan shadow region page tables can't be filled statically because > physical addresses in these page tables depend on phys_base. > Initialize KASan shadow region page tables in kasan_early_init(). Yeah, so please use the customary changelog style we use in the kernel: " Current code does (A), this causes problem (B) when doing (C). In that case the user notices (D). We can improve this doing (E), because (F)." Please fill in (A)-(E) accordingly. Thanks, Ingo