From: Johan Hovold <johan@kernel.org>
To: Abhishek bist <ishubist@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype
Date: Tue, 2 Jun 2015 11:28:39 +0200 [thread overview]
Message-ID: <20150602092839.GB5409@localhost> (raw)
In-Reply-To: <CA+DjjfZpaM4cm728ENHApWY3+apV0bo_ZfeXWXfiZ3zpPGEiwQ@mail.gmail.com>
[ Please avoid top-posting. ]
On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote:
> Yes, I gone through this warning. It is because if i want to make this
> compilation warning free
> than i have to change the prototype of a open function pointer
> described in usb_serial_driver
> and changing the prototype over there would affect all the device
> driver lying in usb-serial
> category , which is definitely not recommended.
Exactly. My point was that this change is neither correct or desired.
And that you need to pay attention to any compilation warning that your
changes cause. ;)
> Anyways i got your point .
Johan
prev parent reply other threads:[~2015-06-02 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 13:17 [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype Abhishek Bist
2015-06-01 14:30 ` Johan Hovold
2015-06-02 9:19 ` Abhishek bist
2015-06-02 9:28 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602092839.GB5409@localhost \
--to=johan@kernel.org \
--cc=ishubist@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox