From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991AbbFBJ2t (ORCPT ); Tue, 2 Jun 2015 05:28:49 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:33912 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754381AbbFBJ2h (ORCPT ); Tue, 2 Jun 2015 05:28:37 -0400 Date: Tue, 2 Jun 2015 11:28:39 +0200 From: Johan Hovold To: Abhishek bist Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] USB-SERIAL : Changing usb_serial_generic_open prototype Message-ID: <20150602092839.GB5409@localhost> References: <1432991840-24152-1-git-send-email-ishubist@gmail.com> <20150601143013.GG27360@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Please avoid top-posting. ] On Tue, Jun 02, 2015 at 02:49:30PM +0530, Abhishek bist wrote: > Yes, I gone through this warning. It is because if i want to make this > compilation warning free > than i have to change the prototype of a open function pointer > described in usb_serial_driver > and changing the prototype over there would affect all the device > driver lying in usb-serial > category , which is definitely not recommended. Exactly. My point was that this change is neither correct or desired. And that you need to pay attention to any compilation warning that your changes cause. ;) > Anyways i got your point . Johan