From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbbFBLwb (ORCPT ); Tue, 2 Jun 2015 07:52:31 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38569 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbbFBLwV (ORCPT ); Tue, 2 Jun 2015 07:52:21 -0400 Date: Tue, 2 Jun 2015 13:52:17 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Peter Zijlstra , LKML Subject: Re: [PATCH] lockdep: Add missing space in error message Message-ID: <20150602115216.GA20524@gmail.com> References: <1432918575-30734-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432918575-30734-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > From: Borislav Petkov > > ... to fix this: > > WARNING: lockdep init error! lock-(console_sem).lock was acquiredbefore lockdep_init > > Signed-off-by: Borislav Petkov > --- > kernel/locking/lockdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index a0831e1b99f4..041ac1add184 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -4066,7 +4066,7 @@ void __init lockdep_info(void) > > #ifdef CONFIG_DEBUG_LOCKDEP > if (lockdep_init_error) { > - printk("WARNING: lockdep init error! lock-%s was acquired" > + printk("WARNING: lockdep init error! lock-%s was acquired " > "before lockdep_init\n", lock_init_error); Please also fix the cause, not just the symptom: the cause is the unnecessary line-break in the middle of a user visible string. Thanks, Ingo