Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()

David Fries
2015-06-11T23:41:57Z

On Thu, Jun 11, 2015 at 06:31:00PM +0300, Evgeniy Polyakov wrote:
> Hi
>
> 04.06.2015, 12:04, "Dan Carpenter" <dan.carpenter@oracle.com>:
> > I noticed there was a problem here because Smatch complained:
> >
> >         drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
> >         inconsistent returns 'mutex:&sl->master->mutex'.
> >           Locked on: line 416
> >           Unlocked on: line 413
> >
> > The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
> > David Fries says that ->bus_mutex is correct and ->mutex is incorrect.
> >
> > Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Looks good to me, Greg please pull this serie into your tree, if you hadn't yet.
> Am I right that this is a stable tree material too?

I would expect the answer to be no. This is a fix to a new feature
that is in gregkh/char-misc but not yet in Linus's tree.