From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -v1.1] lockdep: Do not break user-visible string
Date: Tue, 2 Jun 2015 15:38:27 +0200 [thread overview]
Message-ID: <20150602133827.GD19887@pd.tnic> (raw)
In-Reply-To: <20150602115216.GA20524@gmail.com>
On Tue, Jun 02, 2015 at 01:52:17PM +0200, Ingo Molnar wrote:
> Please also fix the cause, not just the symptom: the cause is the unnecessary
> line-break in the middle of a user visible string.
v1.1:
---
From: Borislav Petkov <bp@suse.de>
Date: Fri, 29 May 2015 18:49:45 +0200
Subject: [PATCH v1.1] lockdep: Do not break user-visible string
Remove the line-break in the user-visible string and add the missing
space in this error message:
WARNING: lockdep init error! lock-(console_sem).lock was acquiredbefore lockdep_init
Signed-off-by: Borislav Petkov <bp@suse.de>
---
kernel/locking/lockdep.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index a0831e1b99f4..4f0b995d86a2 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -4066,8 +4066,7 @@ void __init lockdep_info(void)
#ifdef CONFIG_DEBUG_LOCKDEP
if (lockdep_init_error) {
- printk("WARNING: lockdep init error! lock-%s was acquired"
- "before lockdep_init\n", lock_init_error);
+ printk("WARNING: lockdep init error! lock-%s was acquired before lockdep_init\n", lock_init_error);
printk("Call stack leading to lockdep invocation was:\n");
print_stack_trace(&lockdep_init_trace, 0);
}
--
2.3.5
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-06-02 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 16:56 [PATCH] lockdep: Add missing space in error message Borislav Petkov
2015-06-02 11:52 ` Ingo Molnar
2015-06-02 13:38 ` Borislav Petkov [this message]
2015-06-03 9:30 ` [tip:locking/core] lockdep: Do not break user-visible string tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602133827.GD19887@pd.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox