From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759144AbbFBOgv (ORCPT ); Tue, 2 Jun 2015 10:36:51 -0400 Received: from mail-vn0-f42.google.com ([209.85.216.42]:37915 "EHLO mail-vn0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759265AbbFBOge (ORCPT ); Tue, 2 Jun 2015 10:36:34 -0400 Date: Tue, 2 Jun 2015 11:39:05 -0300 From: Gaston Gonzalez To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, gdonald@gmail.com, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, cristina.opriceana@gmail.com Subject: Re: [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings Message-ID: <20150602143905.GB16349@debsktop1> References: <1433205811-21227-1-git-send-email-gascoar@gmail.com> <20150602053941.GA6382@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150602053941.GA6382@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2015 at 11:09:41AM +0530, Sudip Mukherjee wrote: > On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > > index d2e8b12..d0a6a59 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > > @@ -660,8 +660,10 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be > > auth = (struct ieee80211_authentication *) > > skb_put(skb, sizeof(struct ieee80211_authentication)); > > > > - auth->header.frame_ctl = IEEE80211_STYPE_AUTH; > > - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP; > > + if (challengelen) > > + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP); > it is introducing new checkpatch warning of "line over 80 characters". > > regards > sudip Yes, you are right. I'll send a v3 including with that fixed. Thanks for the feedback, Gaston