public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Peter Hurley <peter@hurleysoftware.com>,
	Jiri Slaby <jslaby@suse.cz>, Borislav Petkov <bp@suse.de>,
	"Stuart R. Anderson" <stuart.r.anderson@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c
Date: Tue, 2 Jun 2015 23:46:02 +0200	[thread overview]
Message-ID: <20150602214601.GA32082@gmail.com> (raw)
In-Reply-To: <20150602192036.GA52512@worksta>


* Bin Gao <bin.gao@linux.intel.com> wrote:

> On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote:
> > 
> > * Bin Gao <bin.gao@linux.intel.com> wrote:
> > 
> > > The arch independent uart8250 early console driver has good support for memory 
> > > mapped and io port based 8250 uarts. Since pci is arch independent so it's 
> > > natural to extend uart8250 to support mem, io and pci. Hence pci uart early 
> > > console in arch/x86/kernel_printk.c by the following commit: 'commit 
> > > 5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its 
> > > equivalent function will be available from uart8250 early console driver.
> > 
> > In what way have you tested this change, does serial-earlyprintk still work on x86 
> > after the change?
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> Yes, this patch was tested with earlyprintk=serial,0x3f8 on my x86 box and
> the early console worked fine.

So the format on x86 used to be:

  earlyprintk=serial,ttyS0,115200

does that work too?

Thanks,

	Ingo

  parent reply	other threads:[~2015-06-02 21:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 18:41 [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c Bin Gao
2015-06-02 11:54 ` Ingo Molnar
2015-06-02 19:20   ` Bin Gao
2015-06-02 20:37     ` Yinghai Lu
2015-06-03  3:00       ` Bin Gao
2015-06-02 21:07     ` Thomas Gleixner
2015-06-02 22:43       ` Bin Gao
2015-06-03  0:16         ` Anderson, Stuart R
2015-06-03  3:09           ` Bin Gao
2015-06-03 12:36           ` Peter Hurley
2015-06-03 16:55         ` Thomas Gleixner
2015-06-02 21:46     ` Ingo Molnar [this message]
2015-06-02 22:34       ` Bin Gao
2015-06-03 12:35 ` Peter Hurley
2015-06-03 16:34   ` Bin Gao
2015-06-08 18:19 ` [PATCH v6 " Bin Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602214601.GA32082@gmail.com \
    --to=mingo@kernel.org \
    --cc=bin.gao@linux.intel.com \
    --cc=bp@suse.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peter@hurleysoftware.com \
    --cc=stuart.r.anderson@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox