public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bin Gao <bin.gao@linux.intel.com>
To: "Anderson, Stuart R" <stuart.r.anderson@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Peter Hurley <peter@hurleysoftware.com>,
	Jiri Slaby <jslaby@suse.cz>, Borislav Petkov <bp@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c
Date: Tue, 2 Jun 2015 20:09:56 -0700	[thread overview]
Message-ID: <20150603030956.GB119305@worksta> (raw)
In-Reply-To: <518B79536261F8469CEA9CC56FA8F74503353E1D@FMSMSX105.amr.corp.intel.com>

On Wed, Jun 03, 2015 at 12:16:36AM +0000, Anderson, Stuart R wrote:
> Bin, et al,
> 
> What we are losing here is the ability to specify a UART by its bus address
> instead of just supplying the memory or io address. There are some cases
> where this is useful, though I admit it is probably not going to be widely
> used. I have seen a platform where the location of the UART moves depending
> on the firmware version, but the bus address (B:D.F) did not change. There
> are also some platforms where you do not know the address until you boot the
> OS and can use the UART to login and find the address of the UART (oops.
> Chicken and egg problem).
> 
> Also, I was going to soon send a patch to allow "pciserial32" for the case where the UART registers are 32-bit aligned instead of 8-bit aligned.
> 
> Stuart
> 

Theare are several reasons that we want to move it to serial_core.
First, pci is arch independent, so putting these codes in serial_core
(which is arch independent) makes more sense.
Second, B:D.F may change across SoCs, then to support new SoC we only
need change command line but don't need to change the code.
Lastly, there could be other non-x86 platforms using it in the future.

-Bin

  reply	other threads:[~2015-06-03  2:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 18:41 [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c Bin Gao
2015-06-02 11:54 ` Ingo Molnar
2015-06-02 19:20   ` Bin Gao
2015-06-02 20:37     ` Yinghai Lu
2015-06-03  3:00       ` Bin Gao
2015-06-02 21:07     ` Thomas Gleixner
2015-06-02 22:43       ` Bin Gao
2015-06-03  0:16         ` Anderson, Stuart R
2015-06-03  3:09           ` Bin Gao [this message]
2015-06-03 12:36           ` Peter Hurley
2015-06-03 16:55         ` Thomas Gleixner
2015-06-02 21:46     ` Ingo Molnar
2015-06-02 22:34       ` Bin Gao
2015-06-03 12:35 ` Peter Hurley
2015-06-03 16:34   ` Bin Gao
2015-06-08 18:19 ` [PATCH v6 " Bin Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603030956.GB119305@worksta \
    --to=bin.gao@linux.intel.com \
    --cc=bp@suse.de \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peter@hurleysoftware.com \
    --cc=stuart.r.anderson@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox