Re: [PATCH 3.14 10/64] xfs: xfs_iozero can return positive errno

Luis Henriques
2015-06-03T13:16:06Z

On Wed, Jun 03, 2015 at 08:42:38PM +0900, Greg Kroah-Hartman wrote:
> 3.14-stable review patch. If anyone has any objections, please let me know.
>

I guess you forgot to drop this patch.

Cheers,
--
Luís

> ------------------
>
> From: Dave Chinner <dchinner@redhat.com>
>
> commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.
>
> It was missed when we converted everything in XFs to use negative error
> numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
> error sign conversion"), and should go back to stable kernels.
>
> Thanks to Brian Foster for noticing it.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -126,7 +126,7 @@ xfs_iozero(
> status = 0;
> } while (count);
>
> - return (-status);
> + return status;
> }
>
> /*
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html