From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbFCIPW (ORCPT ); Wed, 3 Jun 2015 04:15:22 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36287 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152AbbFCIPR (ORCPT ); Wed, 3 Jun 2015 04:15:17 -0400 Date: Wed, 3 Jun 2015 10:15:09 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Darren Hart Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Gabriele Mazzotta , Alex Hung , Matthew Garrett , Dmitry Torokhov , Valdis.Kletnieks@vt.edu, Darren Hart Subject: Re: [PATCH v4 3/3] dell-laptop: Use dell-rbtn instead i8042 filter when possible Message-ID: <20150603081509.GA14980@pali> References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <1432762105-13723-1-git-send-email-pali.rohar@gmail.com> <1432762105-13723-4-git-send-email-pali.rohar@gmail.com> <20150528025213.GA30250@fury.dvhart.com> <20150603035505.GA81094@vmdeb7> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150603035505.GA81094@vmdeb7> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 02 June 2015 20:55:05 Darren Hart wrote: > On Wed, May 27, 2015 at 07:52:13PM -0700, Darren Hart wrote: > > On Wed, May 27, 2015 at 11:28:25PM +0200, Pali Rohár wrote: > > > Until now module dell-laptop registered rfkill device which used i8042 > > > filter function for receiving HW switch rfkill events (handling special > > > keycode). > > > > > > But for some dell laptops there is native ACPI driver dell-rbtn which can > > > receive rfkill events (without i8042 hooks). > > > > > > So this patch will combine best from both sides. It will use native ACPI > > > driver dell-rbtn for receiving events and dell-laptop SMBIOS interface for > > > enabling or disabling radio devices. If ACPI driver or device will not be > > > available fallback to i8042 filter function will be used. > > > > > > Patch also changes module_init() to late_initcall() to ensure that init > > > function will be called after initializing dell-rbtn.c driver. > > > > > > Signed-off-by: Pali Rohár > > > Tested-by: Gabriele Mazzotta > > > Signed-off-by: Darren Hart > > > > > > Several basic checkpatch.pl errors in this one. Please always run checkpatch.pl > > before submitting patches, these sorts of issues should be caught before hitting > > the mailing list. > > > > Please provide some details on the scenarios you have tested to verify you have > > addressed the build and runtime issues reported. > > > > Checking in so this doesn't fall through the cracks. Do you have a v5 in the > works for the 4.2 merge window? > > Thanks, > In last days I did not have time to look at it... When do you need to see v5 if it could go to 4.2? -- Pali Rohár pali.rohar@gmail.com