From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: fix comment mentioning abandoned ASSIGN_ONCE
Date: Wed, 3 Jun 2015 08:18:03 -0700 [thread overview]
Message-ID: <20150603151803.GQ5989@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433283376-19218-1-git-send-email-linux@rasmusvillemoes.dk>
On Wed, Jun 03, 2015 at 12:16:16AM +0200, Rasmus Villemoes wrote:
> Commit 43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to
> WRITE_ONCE(x, val)") left behind this reference.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> include/linux/compiler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 867722591be2..38f0668d40aa 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -450,7 +450,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
> * with an explicit memory barrier or atomic instruction that provides the
> * required ordering.
> *
> - * If possible use READ_ONCE/ASSIGN_ONCE instead.
> + * If possible use READ_ONCE/WRITE_ONCE instead.
> */
> #define __ACCESS_ONCE(x) ({ \
> __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
> --
> 2.1.3
>
prev parent reply other threads:[~2015-06-03 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 22:16 [PATCH] trivial: fix comment mentioning abandoned ASSIGN_ONCE Rasmus Villemoes
2015-06-03 15:18 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603151803.GQ5989@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox