Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

Greg Kroah-Hartman
2015-06-08T19:35:21Z

On Wed, Jun 03, 2015 at 01:20:10PM -0700, Tolga Ceylan wrote:
> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
> warning due its inability to detect the noreturn attribute in
> lbug_with_lock() function inside LBUG macro. With this patch, we unlock
> the spinlock before checking the error condition to resolve this warning.

That's a bug in sparse, not in the code, please don't work around tool
bugs by changing kernel code.

thanks,

greg k-h