From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: peterhuewe@gmx.de, safford@us.ibm.com,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>,
richard.l.maliszewski@intel.com
Subject: Re: [PATCH] tpm: introduce struct tpm_buf
Date: Wed, 3 Jun 2015 10:48:51 -0600 [thread overview]
Message-ID: <20150603164851.GA2222@obsidianresearch.com> (raw)
In-Reply-To: <20150603164334.GA2327@jsakkine-mobl1>
On Wed, Jun 03, 2015 at 07:43:34PM +0300, Jarkko Sakkinen wrote:
> I realized basically the same what you said here when I refined the
> patch (read this email after sending v2) :) I decided that align to 8
> bytes.
Don't use the __attribute__((align)), use just a u64, the effect is
identical, and the latter doesn't rely on compiler specific features.
> I don't think the packed attribute is needed here because now I cast
> the beginning to tpm_input_header, which is a packed struct.
I ment the attributs could be changed on the tpm_input_header, the buf
should just be a u64 array..
Jason
next prev parent reply other threads:[~2015-06-03 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 13:04 [PATCH] tpm: introduce struct tpm_buf Jarkko Sakkinen
2015-06-02 13:18 ` Aw: " Peter Huewe
2015-06-02 14:36 ` Jarkko Sakkinen
2015-06-02 18:13 ` Jason Gunthorpe
2015-06-03 12:23 ` Jarkko Sakkinen
2015-06-03 16:11 ` Jason Gunthorpe
2015-06-03 16:43 ` Jarkko Sakkinen
2015-06-03 16:48 ` Jason Gunthorpe [this message]
2015-06-03 17:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603164851.GA2222@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=richard.l.maliszewski@intel.com \
--cc=safford@us.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox