Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

H. Peter Anvin
2015-06-03T18:03:11Z

On 06/03/2015 10:13 AM, Ingo Molnar wrote:
>>>
>>> Anyway, I like this series except patch 7.
>>>
>> I can't count. I mean all except patch 3 (the vdso one), not 7.
>>

Same here... erk.

>> Although arch/x86/entry might be less of a mouthful.
>
> So see my reply to hpa: it makes sense to collect all things system calls and
> other entry code in a single place, instead of having it scattered all around.
>
> Its internal organization is kept intact, so the vDSO code isn't mixed with other
> bits.

That really doesn't change the fact that it is a completely different
beast, and putting it under entry/ is actively misleading. Having vdso/
as a separate top level is a good thing, I believe.

I really dislike deep hierarchies, as I said, because my experience has
been that they are more confusing than they are helpful, especially over
time. The arch-example of badness is of course arch/x86/kernel, which
is a total catch-all, but

-hpa