Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

H. Peter Anvin
2015-06-03T17:04:47Z

On 06/03/2015 09:59 AM, Ingo Molnar wrote:
> So the x86 syscall/irq/etc. entry code is scattered in
> over 40 files all over the x86 architecture, making it
> hard to get a good overview of the code and its current
> status.
>
> Move all the files to arch/x86/entry/.
>
> This first step is as-is, no file names were changed - but the next
> step will be to organize things in a bit more maintainable fashion.
>
> If there are no fundamental objections then I'll commit this to
> tip:x86/asm. (I've drained most of the pending patches to these
> files - but porting them should be easy in any case.)

I would prefer if it was made a separate topic.

I like the patch set (and you can add my Acked-by:) *except* 7/7, and
the reason for that is that it really isn't entry code, it is user space
code.

I also dislike deep directory hierarchies in general, unless it really
be avoided, like boot/ or realmode/.

-hpa