public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/
Date: Wed, 3 Jun 2015 19:13:32 +0200	[thread overview]
Message-ID: <20150603171332.GD14389@gmail.com> (raw)
In-Reply-To: <CALCETrWOPx=Vhe8bC6a-OfH3VBP9xtETNWBP5ERuy3Yif+8sFA@mail.gmail.com>


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Wed, Jun 3, 2015 at 10:07 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> > On Wed, Jun 3, 2015 at 9:59 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >> So the x86 syscall/irq/etc. entry code is scattered in
> >> over 40 files all over the x86 architecture, making it
> >> hard to get a good overview of the code and its current
> >> status.
> >>
> >> Move all the files to arch/x86/entry/.
> >>
> >> This first step is as-is, no file names were changed - but the next
> >> step will be to organize things in a bit more maintainable fashion.
> >
> > Sort of like this?
> >
> > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/entry&id=d9e37f908e8788c6d50959257f95e279ebdc821d
> >
> > /me cringes at the impending rebase.
> >
> > Anyway, I like this series except patch 7.
> >
> 
> I can't count.  I mean all except patch 3 (the vdso one), not 7.
> 
> Although arch/x86/entry might be less of a mouthful.

So see my reply to hpa: it makes sense to collect all things system calls and 
other entry code in a single place, instead of having it scattered all around.

Its internal organization is kept intact, so the vDSO code isn't mixed with other 
bits.

Thanks,

	Ingo

  reply	other threads:[~2015-06-03 17:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:59 [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 1/7] x86/asm/entry: Move entry_64.S and entry_32.S to arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 2/7] x86/asm/entry: Move the compat syscall entry code " Ingo Molnar
2015-06-03 17:04   ` Andy Lutomirski
2015-06-03 17:11     ` Ingo Molnar
2015-06-03 16:59 ` [PATCH 3/7] x86/asm/entry, x86/vdso: Move the vDSO code to arch/x86/entry/vdso/ Ingo Molnar
2015-06-03 17:05   ` Andy Lutomirski
2015-06-03 16:59 ` [PATCH 4/7] x86/asm/entry: Move the 'thunk' functions to arch/x86/entry/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 5/7] x86/asm/entry: Move arch/x86/include/asm/calling.h " Ingo Molnar
2015-06-03 16:59 ` [PATCH 6/7] x86/asm/entry: Move the arch/x86/syscalls/ definitions to arch/x86/entry/syscalls/ Ingo Molnar
2015-06-03 16:59 ` [PATCH 7/7] x86/asm/entry: Move the vsyscall code to arch/x86/entry/vsyscall/ Ingo Molnar
2015-06-03 17:03 ` [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/ H. Peter Anvin
2015-06-03 17:11   ` Ingo Molnar
2015-06-03 17:13     ` Andy Lutomirski
2015-06-03 17:16       ` Ingo Molnar
2015-06-03 17:21         ` Ingo Molnar
2015-06-03 17:23           ` Andy Lutomirski
2015-06-03 17:29             ` Ingo Molnar
2015-06-03 17:22         ` Andy Lutomirski
2015-06-03 18:04           ` H. Peter Anvin
2015-06-03 18:18             ` H. Peter Anvin
2015-06-03 17:07 ` Andy Lutomirski
2015-06-03 17:08   ` Andy Lutomirski
2015-06-03 17:13     ` Ingo Molnar [this message]
2015-06-03 18:02       ` H. Peter Anvin
2015-06-05  7:37         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603171332.GD14389@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox