Re: [PATCH 01/11] drivers/crypto: include <module.h> for modular caam code

Paul Gortmaker
2015-05-01T13:41:32Z

On 15-04-30 11:24 PM, Herbert Xu wrote:
> On Thu, Apr 30, 2015 at 09:47:37PM -0400, Paul Gortmaker wrote:
>> This file is built off of a tristate Kconfig option and also contains
>> modular function calls so it should explicitly include module.h to
>> avoid compile breakage during header shuffles done in the future.
>>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Please post patches to linux-crypto@vger.kernel.org if you want them
> to go through the crypto tree.

Sure, I will add a CC for that in v2 if the patch is needed.

>
> Also it actually gets module.h through caam/compat.h. So your
> patch is unnecessary.

Well, in my original build testing this file failed to compile once
the modular code was moved from init.h to module.h as per the description
in the 0/11.

Perhaps since that testing something else has changed. I will drop this
patch and retest and if it no longer fails, then great.

Thanks,
Paul.
--

>
> Cheers,
>