From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, joe@perches.com,
devel@driverdev.osuosl.org, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode
Date: Thu, 4 Jun 2015 10:48:08 +0530 [thread overview]
Message-ID: <20150604051753.GA6376@sudip-PC> (raw)
In-Reply-To: <556F458E.20002@gmail.com>
On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
> On 03.06.2015 09:26, Sudip Mukherjee wrote:
> > On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
>
> No, I missed that - this one should also be removed - probably because of similar naming (DbgMode, dbg_mode).
> Thanks for finding it - I'll fix that in v2.
>
> Apart from that - did you had time/courage to analyze rest of the patches (so I can send v2)?
at a first glance looked ok to me. I hope you have checked it on the
hardware as well. but maybe Dan can find something.
better send v2.
regards
sudip
>
next prev parent reply other threads:[~2015-06-04 5:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 20:48 [PATCH 00/11] staging: rtl8192e: Remove dead code Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 01/11] " Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 02/11] staging: rtl8192e: Remove dead code: cmpk_handle_query_config_rx() Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 03/11] staging: rtl8192e: Remove dead code: cmpk_message_handle_rx() Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 04/11] staging: rtl8192e: Remove dead code: read/write_cam Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 05/11] staging: rtl8192e: Remove unused macros/structures in rtl_core.h Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch] Mateusz Kulikowski
2015-06-04 13:52 ` Dan Carpenter
2015-06-07 19:34 ` Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode Mateusz Kulikowski
2015-06-03 7:26 ` Sudip Mukherjee
2015-06-03 18:21 ` Mateusz Kulikowski
2015-06-04 5:18 ` Sudip Mukherjee [this message]
2015-06-04 5:50 ` Mateusz Kulikowski
2015-06-04 6:06 ` Sudip Mukherjee
2015-06-07 19:28 ` Mateusz Kulikowski
2015-06-04 13:53 ` Dan Carpenter
2015-06-02 20:48 ` [PATCH 08/11] staging: rtl8192e: Remove dead code: rt_stats Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 09/11] staging: rtl8192e: Remove dead code: undefined arrays Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 10/11] staging: rtl8192e: Remove dead code: r8192_priv members Mateusz Kulikowski
2015-06-02 20:48 ` [PATCH 11/11] staging: rtl8192e: Remove dead code: mp_adapter Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604051753.GA6376@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox